Scourge Of War - Gettysburg · classic · first seen
This one was hard to track down. I'm not sure how long it's been in the code, but it's ugly. Some really dumb coder made a typo a couple of times and never noticed it. Since C++ basically lets you do anything, there were no obvious issues. That was until players started noticing the attach/detach problem and I would guess some other hidden issues. For those that are interested, I learn more and hopefully others learn more from mistakes.
When coding bit flags, which I use for different states of the units, I brain farted the wrong symbol.
flags &= !detachflag
Seems ok, turn off the detach flag, but that's not the correct symbol, that's a boolean, so it basically messes up every single flag stored.
The correct symbol, that was throughout most of the code was
flags &= ~detachflag
That gives the correct form to disable just the one flag. It's a really really stupid error with ugly results, because there are a lot of flags. I also saw the error in WL, but it's not as prevalent.
Thank you to everyone on the forums for bringing this to our attention.
| Depot | New manifest | Previous manifest |
|---|---|---|
| 3142401 | 6692952281910835621 | — |